friendlymatthew commented on PR #7961: URL: https://github.com/apache/arrow-rs/pull/7961#issuecomment-3092210815
> That last part is my biggest worry -- if it's not safe to physically swap the bytes of two logically equivalent variant objects (because the field ids could go out of sync), what use is logical equivalence? Interesting, I wonder if we scope this custom `PartialEq` implementation on `VariantObject` to purely for tests. Since objects check whether all field entries bijectively map to another objects' field entries, it is quite easy to run into panics or even mutate the field entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
