alamb commented on code in PR #7961:
URL: https://github.com/apache/arrow-rs/pull/7961#discussion_r2222205270
##########
parquet-variant/src/variant/object.rs:
##########
@@ -412,26 +413,24 @@ impl<'m, 'v> VariantObject<'m, 'v> {
// checks whether the field values are equal -- regardless of their order
impl<'m, 'v> PartialEq for VariantObject<'m, 'v> {
fn eq(&self, other: &Self) -> bool {
- let mut is_equal = self.metadata == other.metadata
- && self.header == other.header
- && self.num_elements == other.num_elements
- && self.first_field_offset_byte == other.first_field_offset_byte
- && self.first_value_byte == other.first_value_byte
- && self.validated == other.validated;
-
- // value validation
+ if self.num_elements != other.num_elements {
+ return false;
+ }
+
let other_fields: HashMap<&str, Variant> =
HashMap::from_iter(other.iter());
for (field_name, variant) in self.iter() {
match other_fields.get(field_name as &str) {
Some(other_variant) => {
Review Comment:
@friendlymatthew are you willing to make this change? I can give it a shot
too if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
