Dandandan commented on code in PR #7984: URL: https://github.com/apache/arrow-rs/pull/7984#discussion_r2227956335
########## arrow-array/src/builder/generic_bytes_builder.rs: ########## @@ -126,15 +127,16 @@ impl<T: ByteArrayType> GenericByteBuilder<T> { #[inline] pub fn append_null(&mut self) { self.null_buffer_builder.append(false); - self.offsets_builder.append(self.next_offset()); + self.offsets_builder.push(self.next_offset()); } /// Appends `n` `null`s into the builder. #[inline] pub fn append_nulls(&mut self, n: usize) { self.null_buffer_builder.append_n_nulls(n); let next_offset = self.next_offset(); - self.offsets_builder.append_n(n, next_offset); + self.offsets_builder + .extend(std::iter::repeat(next_offset).take(n)); Review Comment: `repeat_n`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org