Dandandan commented on code in PR #7984:
URL: https://github.com/apache/arrow-rs/pull/7984#discussion_r2227957793


##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -184,11 +186,11 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
         let array_type = T::DATA_TYPE;
         let array_builder = ArrayDataBuilder::new(array_type)
             .len(self.len())
-            .add_buffer(self.offsets_builder.finish())
-            .add_buffer(self.value_builder.finish())
+            .add_buffer(Buffer::from_vec(std::mem::take(&mut 
self.offsets_builder)))

Review Comment:
   Should be able to use `into()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to