edponce commented on pull request #10016: URL: https://github.com/apache/arrow/pull/10016#issuecomment-819001359
The following are pending details to be resolved with this PR: 1. How to handle 0, +0, -0? IEEE754 defines signed/unsigned zero and although they should be logically equal, they can produce different results on certain operations. For example, 1/-0 = -inf and 1/+0 = +inf 2. How to handle unsigned integers? Wrap around as described in https://en.cppreference.com/w/cpp/language/implicit_conversion 3. Test cases for int8 and int16 fail because expected result is implicitly promoted to int32. Not sure if this promotion occurs in testing framework or C++ rules. @bkietz @pitrou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
