JakeDern commented on code in PR #8001:
URL: https://github.com/apache/arrow-rs/pull/8001#discussion_r2271120613
##########
arrow-ipc/src/reader.rs:
##########
@@ -1597,6 +1660,122 @@ impl<R: Read> RecordBatchReader for StreamReader<R> {
}
}
+/// Representation of a fully parsed IpcMessage from the underlying stream.
+/// Parsing this kind of message is done by higher level constructs such as
+/// [`StreamReader`], because fully interpreting the messages into a record
+/// batch or dictionary batch requires access to stream state such as schema
+/// and the full dictionary cache.
+#[derive(Debug)]
+#[allow(dead_code)]
Review Comment:
Yeah this is used by that `next_ipc_message` API that I added. It's used by
both test and library code, but some of the fields are only accessed in tests
hence the dead code. I'd like to rely completely on this API for the
StreamReader implementation, including in the constructor for getting the
schema, but there are further refactoring that I think we would need to make
that possible. Currently the constructor uses just the `MessageReader` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
