klion26 commented on code in PR #8114:
URL: https://github.com/apache/arrow-rs/pull/8114#discussion_r2272107157
##########
parquet-variant-json/src/to_json.rs:
##########
@@ -457,6 +472,20 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_time_to_json() -> Result<(), ArrowError> {
+ let naive_time = NaiveTime::from_num_seconds_from_midnight_opt(12345,
123460708).unwrap();
+ let variant = Variant::Time(naive_time);
+ let json = variant_to_json_string(&variant)?;
+ assert!(json.contains("03:25:45.12346"));
+ assert!(json.starts_with('"') && json.ends_with('"'));
+
+ let json_value = variant_to_json_value(&variant)?;
+ assert!(matches!(json_value, Value::String(_)));
+ println!("{:?}", json);
Review Comment:
fixed in the followup pr(will push remote after `parquet-testing` pr has
been merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
