alamb commented on PR #8093: URL: https://github.com/apache/arrow-rs/pull/8093#issuecomment-3201777401
> Additionally, I list some comments outlining potential next steps or action items in the following, FYI. > > 1. VariantArray::value() to return Option to properly distinguish SQL NULL vs JSON null I agree with @scovich that VariantArray::value() should continue to return `Variant` (not `Option<Variant>`) -- and the elements which where null (the validity mask was 0) `VariantArray::value()`, should return the item in the array at that location (which should be `Variant::Null` in this case, though that may not happen tody) > 2. Add validation to reject top-level AllNull variants entirely 👍 > 3. Pass schema information to ShreddingState::try_new() to detect context > 4. Split AllNull handling into separate variants for top-level vs shredded contexts I think this makes sense to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
