lidavidm commented on code in PR #3320:
URL: https://github.com/apache/arrow-adbc/pull/3320#discussion_r2292445995
##########
c/driver_manager/CMakeLists.txt:
##########
Review Comment:
We may need similar checks in other builds? (R driver manager?)
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -1362,6 +1414,22 @@ AdbcStatusCode
AdbcDriverManagerDatabaseSetLoadFlags(struct AdbcDatabase* databa
return ADBC_STATUS_OK;
}
+AdbcStatusCode AdbcDriverManagerDatabaseSetAdditionalSearchPathList(
+ struct AdbcDatabase* database, const char* path_list, struct AdbcError*
error) {
+ if (database->private_driver) {
+ SetError(error, "Cannot SetAdditionalSearchPathList after
AdbcDatabaseInit");
+ return ADBC_STATUS_INVALID_STATE;
+ }
+
+ TempDatabase* args = reinterpret_cast<TempDatabase*>(database->private_data);
+ if (path_list) {
+ args->additional_search_path_list = path_list;
Review Comment:
IMO this isn't safe. We should store an allocated std::string.
##########
docs/source/format/driver_manifests.rst:
##########
Review Comment:
Should we note that CONDA_PREFIX is only searched if configured at build
time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
