scovich commented on code in PR #8208:
URL: https://github.com/apache/arrow-rs/pull/8208#discussion_r2296027615
##########
parquet-variant/src/builder.rs:
##########
@@ -589,14 +675,14 @@ enum ParentState<'a> {
Variant {
value_builder: &'a mut ValueBuilder,
saved_value_builder_offset: usize,
- metadata_builder: &'a mut MetadataBuilder,
+ metadata_builder: &'a mut dyn MetadataBuilder,
Review Comment:
A related issue we'll hit shortly: `VariantArrayBuilder` is currently
hard-wired to use a `BasicMetadataBuilder` that produces a new metadata column.
Once we need a variant array builder that uses-and-preserves an existing
metadata column (e.g. for unshredding), we'll be forced to decide whether we
want to make `VariantArrayBuilder` generic over `M: MetadataBuilder` or just
define a second builder class.
I suspect that choice will ultimately decide the generic-vs-not question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
