HuaHuaY commented on code in PR #47427:
URL: https://github.com/apache/arrow/pull/47427#discussion_r2306091256
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -795,9 +795,10 @@ class ParquetIOTestBase : public ::testing::Test {
class TestReadDecimals : public ParquetIOTestBase {
public:
- void CheckReadFromByteArrays(const std::shared_ptr<const LogicalType>&
logical_type,
- const std::vector<std::vector<uint8_t>>& values,
- const Array& expected) {
+ void CheckReadFromByteArrays(
+ const std::shared_ptr<const LogicalType>& logical_type,
+ const std::vector<std::vector<uint8_t>>& values, const Array& expected,
+ ArrowReaderProperties properties = default_arrow_reader_properties()) {
Review Comment:
Here `properties` cannot be `const &` because its binary type will be
changed at line 826.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
