codephage2020 commented on code in PR #8233:
URL: https://github.com/apache/arrow-rs/pull/8233#discussion_r2310569523
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -143,7 +152,14 @@ fn convert_timestamp(
/// `1970-01-01T00:00:01.234567890Z`
/// will be truncated to
/// `1970-01-01T00:00:01.234567Z`
-pub fn cast_to_variant(input: &dyn Array) -> Result<VariantArray, ArrowError> {
+///
+/// # Arguments
+/// * `input` - The array to convert to VariantArray
+/// * `strict` - If true, return error on conversion failure. If false, insert
null for failed conversions.
+pub fn cast_to_variant_with_options(
+ input: &dyn Array,
+ strict: bool,
Review Comment:
Yes, very good discovery. I have thought about this implementation. We can
refactor this part in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
