scott-routledge2 commented on code in PR #43698:
URL: https://github.com/apache/arrow/pull/43698#discussion_r2319324976
##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -459,6 +465,11 @@ class ARROW_DS_EXPORT Scanner {
TaggedRecordBatchIterator scan);
const std::shared_ptr<ScanOptions> scan_options_;
+
+ ::arrow::internal::Executor* async_cpu_executor() const {
+ return scan_options_->exec_context.executor() ?
scan_options_->exec_context.executor()
+ :
::arrow::internal::GetCpuThreadPool();
+ }
Review Comment:
Thanks! I already made the change to remove ExecContext and I agree that
this is not necessary for the synchronous functions, but I believe we still
need some kind of way of checking if `scan_options_->cpu_executor`is null
before passing to the async versions like `ScanBatchesUnorderedAsync`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
