jecsand838 commented on code in PR #8274:
URL: https://github.com/apache/arrow-rs/pull/8274#discussion_r2322702309
##########
arrow-avro/src/writer/encoder.rs:
##########
@@ -17,25 +17,26 @@
//! Avro Encoder for Arrow types.
+use crate::codec::{AvroDataType, AvroField, Codec};
+use crate::schema::Nullability;
use arrow_array::cast::AsArray;
use arrow_array::types::{
- ArrowPrimitiveType, Float32Type, Float64Type, Int32Type, Int64Type,
TimestampMicrosecondType,
+ ArrowPrimitiveType, Float32Type, Float64Type, Int32Type, Int64Type,
IntervalMonthDayNanoType,
+ TimestampMicrosecondType,
+};
+use arrow_array::{
+ Array, Decimal128Array, Decimal256Array, Decimal32Array, Decimal64Array,
DictionaryArray,
+ FixedSizeBinaryArray, GenericBinaryArray, GenericListArray,
GenericStringArray, LargeListArray,
+ ListArray, MapArray, OffsetSizeTrait, PrimitiveArray, RecordBatch,
StringArray, StructArray,
};
-use arrow_array::OffsetSizeTrait;
-use arrow_array::{Array, GenericBinaryArray, PrimitiveArray, RecordBatch};
use arrow_buffer::NullBuffer;
-use arrow_schema::{ArrowError, DataType, FieldRef, TimeUnit};
+use arrow_schema::{ArrowError, DataType, Field, IntervalUnit, Schema as
ArrowSchema, TimeUnit};
use std::io::Write;
+use std::sync::Arc;
+use uuid::Uuid;
-/// Behavior knobs for the Avro encoder.
-///
-/// When `impala_mode` is `true`, optional/nullable values are encoded
-/// as Avro unions with **null second** (`[T, "null"]`). When `false`
-/// (default), we use **null first** (`["null", T]`).
-#[derive(Debug, Clone, Copy, Default)]
-pub struct EncoderOptions {
- impala_mode: bool, // Will be fully implemented in a follow-up PR
-}
+/// Plan reference passed to the unified encoder constructor (required).
+type PlanRef<'p> = &'p FieldPlan;
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
