jecsand838 commented on code in PR #8274:
URL: https://github.com/apache/arrow-rs/pull/8274#discussion_r2317718792
##########
arrow-avro/src/codec.rs:
##########
@@ -28,19 +28,6 @@ use std::borrow::Cow;
use std::collections::HashMap;
use std::sync::Arc;
-/// Avro types are not nullable, with nullability instead encoded as a union
-/// where one of the variants is the null type.
-///
-/// To accommodate this we special case two-variant unions where one of the
-/// variants is the null type, and use this to derive arrow's notion of
nullability
-#[derive(Debug, Copy, Clone, PartialEq)]
-pub enum Nullability {
- /// The nulls are encoded as the first union variant
- NullFirst,
- /// The nulls are encoded as the second union variant
- NullSecond,
-}
Review Comment:
I moved this to `src/schema.rs` to keep the imports clean and non-circular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
