etseidl commented on code in PR #8264:
URL: https://github.com/apache/arrow-rs/pull/8264#discussion_r2322656939
##########
parquet/src/column/page.rs:
##########
@@ -207,7 +207,6 @@ impl CompressedPage {
type_: page_type.into(),
uncompressed_page_size: uncompressed_size as i32,
compressed_page_size: compressed_size as i32,
- // TODO: Add support for crc checksum
Review Comment:
This change is unrelated. AFAICT CRCs still aren't implemented on write.
##########
parquet/src/file/writer.rs:
##########
@@ -966,7 +966,19 @@ impl<W: Write + Send> PageWriter for
SerializedPageWriter<'_, W> {
let mut spec = PageWriteSpec::new();
spec.page_type = page_type;
spec.uncompressed_size = page.uncompressed_size() + header_size;
+ if spec.uncompressed_size > i32::MAX as usize {
Review Comment:
I think we'll need this check everywhere `PageWriter` is implemented (namely
also in `arrow/arrow_writer/mod.rs`). Perhaps it would be better to add some
validation to the `PageWriteSpec` struct itself. Maybe add some setters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
