mapleFU commented on code in PR #8264:
URL: https://github.com/apache/arrow-rs/pull/8264#discussion_r2325341569
##########
parquet/src/file/writer.rs:
##########
@@ -966,7 +966,19 @@ impl<W: Write + Send> PageWriter for
SerializedPageWriter<'_, W> {
let mut spec = PageWriteSpec::new();
spec.page_type = page_type;
spec.uncompressed_size = page.uncompressed_size() + header_size;
+ if spec.uncompressed_size > i32::MAX as usize {
Review Comment:
Now I have time for this part of the code. `pub struct PageWriteSpec` is
widely used and it already uses usize. Should I just add setters like:`fn
set_sizes(compressed, uncompressed) -> Result<()>`, or set the
uncompressed_size to private and add visitors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
