jecsand838 commented on PR #8274: URL: https://github.com/apache/arrow-rs/pull/8274#issuecomment-3256030690
@scovich @nathaniel-d-ef I really appreciate the solid reviews. The changes I just pushed should address most of your feedback. There are two items I wanted to follow-up on in future PRs: 1. Further `arrow-avro/src/schema.rs` file refactoring. As I update the file I saw other potential areas to improve. For example, I think if we introduced some sort of struct to hold context for `datatype_to_avro`, we could simplify and improve the logic. 2. Renaming `Nullability`. The name change will impact other areas of the code not related to the `Writer`. I'd also want to consider the impact `Union` type support will have as well when we get there. But I do think @scovich has a valid point about the current naming convention. Let me know what you all think and what else needs to be done to get this PR into solid shape whenever you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
