AlenkaF commented on PR #47461:
URL: https://github.com/apache/arrow/pull/47461#issuecomment-3265370562
Thank you for another contribution @rmnskb !
The overall approach looks good to me. I like that you're only appending the
read and write options when they're defined. I think we don’t currently have
`wrap_options` functionality to reconstruct the Python `Ipc*Options` from
`self.options.read/write_options`, so holding on to the original Python objects
makes sense.
One request from me — it would be great to add `__repr__` tests, though
there aren’t many currently.
One very minor nit: stylistically, I’d consider adding the parentheses
inside the class name in the `__repr__`, like this:
```python
def __repr__(self):
return (f"<pyarrow.ipc.IpcReadOptions ("
...
f"included_fields={self.included_fields})>")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
