raulcd commented on code in PR #47461:
URL: https://github.com/apache/arrow/pull/47461#discussion_r2348562977


##########
python/pyarrow/_flight.pyx:
##########
@@ -122,6 +125,9 @@ cdef class FlightCallOptions(_Weakrefable):
         """
         cdef IpcWriteOptions c_write_options
 
+        self._py_write_options = write_options
+        self._py_read_options = read_options

Review Comment:
   I agree with @pitrou , when debugging printing info we might want to know 
what are the default Read/Write options. Probably the best option would be to 
create a wrapper for read/write ipc options similar to what we do for:
   ```
   cdef _wrap_read_stats(CIpcReadStats c):
       return ReadStats(c.num_messages, c.num_record_batches,
                        c.num_dictionary_batches, c.num_dictionary_deltas,
                        c.num_replaced_dictionaries)
   ```
   and use `self.options.write_options` and `self.options.read_options`  once 
the object is constructed to generate `IpcReadOptions`/`IpcWriteOptions` either 
via defaults or via the ones passed so we can use them on the `parts.append` 
below. This would allow us to repr default options too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to