wgtmac commented on code in PR #47524:
URL: https://github.com/apache/arrow/pull/47524#discussion_r2332338039
##########
cpp/src/arrow/csv/writer_test.cc:
##########
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+#include "arrow/csv/options.h"
Review Comment:
```suggestion
```
##########
cpp/src/arrow/csv/options.h:
##########
@@ -188,6 +188,12 @@ struct ARROW_EXPORT WriteOptions {
/// Whether to write an initial header line with column names
bool include_header = true;
+ /// \brief Quoting style of header
+ ///
+ /// If `quoting_header` is `QuotingStyle::None`, then only write quotes when
a column
+ /// name contains structural characters. Otherwise, always quote column
names.
+ QuotingStyle quoting_header = QuotingStyle::AllValid;
Review Comment:
If we do not respect all values from `QuotingStyle`, why not simply use a
bool to indicate whether to quote all or needed fields of the header? For
example: `bool header_quote_all_fields`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
