scovich opened a new issue, #8317: URL: https://github.com/apache/arrow-rs/issues/8317
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Today, `variant_get` uses `arrow::compute::CastOptions` whose `safe` flag dictates whether to return NULL or error out. Meanwhile, `cast_to_variant` uses `parquet_variant_compute::CastOptions`, whose `strict` flag dictates whether to error out or return NULL. It's unclear to me whether it's helpful to use two different `CastOptions` for operations that are both the same if you squint? (in particular, doing a `variant_get` with Some VariantType as the requested type (once the extension type exists) should in theory behave identically to `variant_get` with None as the requested type, followed by a call to `cast_to_variant` on the result? At a minimum, we should probably reconcile the `safe` vs `strict` disparity -- there's no good reason to have different names for the same concept. **Describe the solution you'd like** Not sure, it just seems like a wart that will eventually cause problems or confusion. **Describe alternatives you've considered** One of: * Both use arrow's normal `CastOptions` * Both use the new variant compute `CastOptions` * Keep using the different cast option types, but rename the variant `CastOptions::strict` to `safe` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
