alamb commented on issue #8317: URL: https://github.com/apache/arrow-rs/issues/8317#issuecomment-3299779458
We also discussed this a bit on the initial PR that added `CastOptions`: https://github.com/apache/arrow-rs/pull/8233#discussion_r2326099368 and I think some of that is relevant here, specifically some of the rationale > I thought more about this and I think a dedicated CastOptions struct makes sense for variant > Specifically they are different kernels and so some options like FormatOptions for the normal cast kernel may not be relevant for this one > Keep using the different cast option types, but rename the variant CastOptions::strict to safe I worry about using `safe` as it may be confused with the Rust notion of `unsafe` 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
