etseidl commented on code in PR #8312:
URL: https://github.com/apache/arrow-rs/pull/8312#discussion_r2345007838
##########
parquet/src/schema/types.rs:
##########
@@ -1137,11 +1160,13 @@ fn build_tree<'a>(
Type::PrimitiveType { .. } => {
let mut path: Vec<String> = vec![];
path.extend(path_so_far.iter().copied().map(String::from));
+ let column_path = ColumnPath::new(path);
+ leaf_to_idx.insert(column_path.clone(), leaves.len());
Review Comment:
I second this concern. While working on the new metadata parser I've found
that a considerable amount of time is already spent in `build_tree`, and much
of that time is in allocations for the column path. I'd like to profile this
before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
