jhorstmann commented on code in PR #8312:
URL: https://github.com/apache/arrow-rs/pull/8312#discussion_r2340540486


##########
parquet/src/schema/types.rs:
##########
@@ -1006,6 +1006,9 @@ pub struct SchemaDescriptor {
     /// -- -- -- -- d
     /// ```
     leaf_to_base: Vec<usize>,
+
+    /// Mapping between the column dotstring path to the leaf index.
+    leaf_to_idx: HashMap<String, usize>,

Review Comment:
   I feel that if this map is needed, it should use `ColumnPath` as a key. As 
far as I know there is nothing preventing a field name to contain embedded 
dots, so the string representation might not be deterministic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to