jecsand838 commented on code in PR #8349:
URL: https://github.com/apache/arrow-rs/pull/8349#discussion_r2370726024
##########
arrow-avro/src/reader/record.rs:
##########
@@ -991,10 +1096,327 @@ impl Decoder {
.map_err(|e| ArrowError::ParseError(e.to_string()))?;
Arc::new(vals)
}
+ Self::Union(u) => u.flush(nulls)?,
})
}
}
+#[derive(Debug)]
+struct DispatchLookupTable {
+ to_reader: Box<[i16]>,
+ promotion: Box<[Promotion]>,
Review Comment:
I just went with boxed because these tables are built once and then only
read from on the hot path.
My understanding is that using a boxed slice encodes that invariant in the
type, avoids carrying spare capacity, and makes the table field a machine word
smaller than a `Vec` (no capacity word). I was thinking that it’s the same
codegen for indexing, just slightly leaner, with a fixed‑size owner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
