jecsand838 commented on PR #8349: URL: https://github.com/apache/arrow-rs/pull/8349#issuecomment-3322135934
@scovich Thanks for the solid follow-up! I just pushed a commit that addresses your comments. Also to answer those questions you had: > * [#8349 (comment)](https://github.com/apache/arrow-rs/pull/8349#discussion_r2370445402) - Should bytes -> string promotion validate that the bytes contain only valid utf-8? I thought about it more and realized adding the `utf-8` check now is a good idea. I'm planning a fast follow-up to refine the promotion logic and can determine whether a feature flag to toggle that check off in the hot path is worth it then. Just pushed that change up. > * [#8349 (comment)](https://github.com/apache/arrow-rs/pull/8349#discussion_r2370475369) - Can `UnionDecoder` use a three-valued enum instead of a pair of booleans to capture the three valid stats? Or is there a legit reason somebody needs us to support the false/false case as passthrough? I looked at the code again and didn't see a legitimate case where `UnionDecoder` should be constructed if neither side is a union, i.e. `(false, false) => Passthrough`. My latest push cleaned that up. CC: @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
