alamb commented on code in PR #8437:
URL: https://github.com/apache/arrow-rs/pull/8437#discussion_r2376561152
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -873,39 +855,15 @@ impl ParquetMetaDataReader {
}
}
- /// Decodes the end of the Parquet footer
- ///
- /// There are 8 bytes at the end of the Parquet footer with the following
layout:
- /// * 4 bytes for the metadata length
- /// * 4 bytes for the magic bytes 'PAR1' or 'PARE' (encrypted footer)
- ///
- /// ```text
- /// +-----+------------------+
- /// | len | 'PAR1' or 'PARE' |
- /// +-----+------------------+
- /// ```
+ /// Decodes a [`FooterTail`] from the provided 8-byte slice.
pub fn decode_footer_tail(slice: &[u8; FOOTER_SIZE]) -> Result<FooterTail>
{
- let magic = &slice[4..];
Review Comment:
the code to parse the footer was previously a member function of
ParquetMetadataReader, but I need to use it in the ParquetMetadataPushDecoder,
so I pulled it into its own function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
