eric-wang-1990 commented on code in PR #3474:
URL: https://github.com/apache/arrow-adbc/pull/3474#discussion_r2380872497
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -58,19 +58,15 @@ internal class DatabricksConnection : SparkHttpConnection
private bool _enableMultipleCatalogSupport = true;
private bool _enablePKFK = true;
private bool _runAsyncInThrift = true;
-
- internal static TSparkGetDirectResults defaultGetDirectResults = new()
- {
- MaxRows = 2000000,
- MaxBytes = 404857600
- };
-
+ private const int DefaultMaxRowsPerFetchRequest = 1000;
Review Comment:
Why we set this to 1000? That is too small.
The OSS JDBC driver set to 2million for max rows and 404857600 for max
bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
