msrathore-db commented on code in PR #3474:
URL: https://github.com/apache/arrow-adbc/pull/3474#discussion_r2380907881
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -58,19 +58,15 @@ internal class DatabricksConnection : SparkHttpConnection
private bool _enableMultipleCatalogSupport = true;
private bool _enablePKFK = true;
private bool _runAsyncInThrift = true;
-
- internal static TSparkGetDirectResults defaultGetDirectResults = new()
- {
- MaxRows = 2000000,
- MaxBytes = 404857600
- };
-
+ private const int DefaultMaxRowsPerFetchRequest = 1000;
Review Comment:
This was the default value being used earlier.
We'll hold this PR until we find the optimal default value based on perf
analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
