jecsand838 commented on code in PR #8595:
URL: https://github.com/apache/arrow-rs/pull/8595#discussion_r2429938049
##########
arrow-avro/src/schema.rs:
##########
@@ -428,25 +434,29 @@ impl AvroSchema {
build_canonical(schema, None)
}
- /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order.
+ /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order and optionally stripping internal Arrow metadata.
Review Comment:
We shouldn't. By adding metadata that is irrelevant to an Avro Schema, we
are just polluting the schema and complicating round tripping imo.
I think there's actually a risk of us running into issues by keeping the
metadata present. I can foresee future contributors adding Reader behavior
based on internal metadata that unnecessarily complicate decoder behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
