alamb commented on code in PR #8595:
URL: https://github.com/apache/arrow-rs/pull/8595#discussion_r2430388852
##########
arrow-schema/src/error.rs:
##########
@@ -46,6 +46,8 @@ pub enum ArrowError {
CsvError(String),
/// Error during JSON-related operations.
JsonError(String),
+ /// Error during Avro-related operations.
+ AvroError(String),
Review Comment:
This is an API change so we should get it in before arrow-57 is released
##########
arrow-avro/src/schema.rs:
##########
@@ -428,25 +434,29 @@ impl AvroSchema {
build_canonical(schema, None)
}
- /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order.
+ /// Build Avro JSON from an Arrow [`ArrowSchema`], applying the given
null‑union order and optionally stripping internal Arrow metadata.
///
/// If the input Arrow schema already contains Avro JSON in
/// [`SCHEMA_METADATA_KEY`], that JSON is returned verbatim to preserve
/// the exact header encoding alignment; otherwise, a new JSON is generated
/// honoring `null_union_order` at **all nullable sites**.
pub(crate) fn from_arrow_with_options(
schema: &ArrowSchema,
- null_order: Option<Nullability>,
+ options: Option<AvroSchemaOptions>,
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
