amol- commented on a change in pull request #10101:
URL: https://github.com/apache/arrow/pull/10101#discussion_r616005809
##########
File path: python/pyarrow/array.pxi
##########
@@ -1170,7 +1170,9 @@ cdef class Array(_PandasConvertible):
array = PyObject_to_object(out)
if isinstance(array, dict):
+ missings = array["indices"] < 0
array = np.take(array['dictionary'], array['indices'])
+ array[missings] = np.NaN
Review comment:
I noticed I also have to check for interaction with zero copy. Given
that we are ending up _writing_ to `array[missings]` in the end. Nulls should
not be around when zero copy is requested, but better to have a test to see
that it deals with that well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
