amol- commented on a change in pull request #10101:
URL: https://github.com/apache/arrow/pull/10101#discussion_r616795078
##########
File path: python/pyarrow/array.pxi
##########
@@ -1170,7 +1170,13 @@ cdef class Array(_PandasConvertible):
array = PyObject_to_object(out)
if isinstance(array, dict):
- array = np.take(array['dictionary'], array['indices'])
+ if zero_copy_only or not self.null_count:
+ # zero_copy doesn't allow for nulls to be in the array
+ array = np.take(array['dictionary'], array['indices'])
+ else:
+ missings = array["indices"] < 0
+ array = np.take(array['dictionary'], array['indices'])
+ array[missings] = np.NaN
Review comment:
Ok, just wanted to make sure we didn't introduced inconsistencies in the
APIs by chance.
I'll go in the direction of having the `to_numpy()` return the same values
it would return with a normal `Array` and I'll check what's the impact of
converting the `DictionaryArray` to a plain `Array` before doing the
conversion when there are nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
