CommanderStorm commented on code in PR #498:
URL:
https://github.com/apache/arrow-rs-object-store/pull/498#discussion_r2470768782
##########
src/aws/builder.rs:
##########
@@ -318,16 +318,25 @@ pub enum AmazonS3ConfigKey {
/// Set the container credentials relative URI when used in ECS
///
///
<https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_credentials_relative_uri`
Review Comment:
```suggestion
/// - `aws_container_credentials_relative_uri`
/// - `container_credentials_relative_uri`
```
##########
src/aws/builder.rs:
##########
@@ -318,16 +318,25 @@ pub enum AmazonS3ConfigKey {
/// Set the container credentials relative URI when used in ECS
///
///
<https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_credentials_relative_uri`
ContainerCredentialsRelativeUri,
/// Set the container credentials full URI when used in EKS
///
///
<https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_credentials_full_uri`
Review Comment:
```suggestion
/// - `aws_container_credentials_full_uri`
/// - `container_credentials_full_uri`
```
##########
src/aws/builder.rs:
##########
@@ -318,16 +318,25 @@ pub enum AmazonS3ConfigKey {
/// Set the container credentials relative URI when used in ECS
///
///
<https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_credentials_relative_uri`
ContainerCredentialsRelativeUri,
/// Set the container credentials full URI when used in EKS
///
///
<https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_credentials_full_uri`
ContainerCredentialsFullUri,
/// Set the authorization token in plain text when used in EKS to
authenticate with ContainerCredentialsFullUri
///
///
<https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html>
+ ///
+ /// Supported keys:
+ /// - `aws_container_authorization_token_file`
Review Comment:
```suggestion
/// - `aws_container_authorization_token_file`
/// - `container_authorization_token_file`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
