CommanderStorm commented on code in PR #498:
URL:
https://github.com/apache/arrow-rs-object-store/pull/498#discussion_r2470786453
##########
src/aws/builder.rs:
##########
@@ -1202,17 +1226,37 @@ fn parse_bucket_az(bucket: &str) -> Option<&str> {
#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Serialize, Deserialize)]
#[non_exhaustive]
pub enum S3EncryptionConfigKey {
- /// Type of encryption to use. If set, must be one of "AES256" (SSE-S3),
"aws:kms" (SSE-KMS), "aws:kms:dsse" (DSSE-KMS) or "sse-c".
+ /// Type of encryption to use.
+ ///
+ /// If set, must be one of
+ /// - "AES256" (SSE-S3),
+ /// - "aws:kms" (SSE-KMS),
+ /// - "aws:kms:dsse" (DSSE-KMS) or
+ /// - "sse-c"
+ ///
+ /// Supported keys:
+ /// - `aws_server_side_encryption`
ServerSideEncryption,
- /// The KMS key ID to use for server-side encryption. If set,
ServerSideEncryption
- /// must be "aws:kms" or "aws:kms:dsse".
+ /// The KMS key ID to use for server-side encryption.
+ ///
+ /// If set, [ServerSideEncryption](Self::ServerSideEncryption) must be
"aws:kms" or "aws:kms:dsse".
+ ///
+ /// Supported keys:
+ /// - `aws_sse_kms_key_id`
Review Comment:
```suggestion
/// - `aws_sse_kms_key_id`
/// - `sse_kms_key_id`
```
##########
src/aws/builder.rs:
##########
@@ -1202,17 +1226,37 @@ fn parse_bucket_az(bucket: &str) -> Option<&str> {
#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Serialize, Deserialize)]
#[non_exhaustive]
pub enum S3EncryptionConfigKey {
- /// Type of encryption to use. If set, must be one of "AES256" (SSE-S3),
"aws:kms" (SSE-KMS), "aws:kms:dsse" (DSSE-KMS) or "sse-c".
+ /// Type of encryption to use.
+ ///
+ /// If set, must be one of
+ /// - "AES256" (SSE-S3),
+ /// - "aws:kms" (SSE-KMS),
+ /// - "aws:kms:dsse" (DSSE-KMS) or
+ /// - "sse-c"
+ ///
+ /// Supported keys:
+ /// - `aws_server_side_encryption`
ServerSideEncryption,
- /// The KMS key ID to use for server-side encryption. If set,
ServerSideEncryption
- /// must be "aws:kms" or "aws:kms:dsse".
+ /// The KMS key ID to use for server-side encryption.
+ ///
+ /// If set, [ServerSideEncryption](Self::ServerSideEncryption) must be
"aws:kms" or "aws:kms:dsse".
+ ///
+ /// Supported keys:
+ /// - `aws_sse_kms_key_id`
KmsKeyId,
/// If set to true, will use the bucket's default KMS key for server-side
encryption.
/// If set to false, will disable the use of the bucket's default KMS key
for server-side encryption.
+ ///
+ /// Supported keys:
+ /// - `aws_sse_bucket_key_enabled`
BucketKeyEnabled,
/// The base64 encoded, 256-bit customer encryption key to use for
server-side encryption.
- /// If set, ServerSideEncryption must be "sse-c".
+ ///
+ /// If set, [ServerSideEncryption](Self::ServerSideEncryption) must be
"sse-c".
+ ///
+ /// Supported keys:
+ /// - `aws_sse_customer_key_base64`
Review Comment:
```suggestion
/// - `aws_sse_customer_key_base64`
/// - `sse_customer_key_base64`
```
##########
src/aws/builder.rs:
##########
@@ -1202,17 +1226,37 @@ fn parse_bucket_az(bucket: &str) -> Option<&str> {
#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Serialize, Deserialize)]
#[non_exhaustive]
pub enum S3EncryptionConfigKey {
- /// Type of encryption to use. If set, must be one of "AES256" (SSE-S3),
"aws:kms" (SSE-KMS), "aws:kms:dsse" (DSSE-KMS) or "sse-c".
+ /// Type of encryption to use.
+ ///
+ /// If set, must be one of
+ /// - "AES256" (SSE-S3),
+ /// - "aws:kms" (SSE-KMS),
+ /// - "aws:kms:dsse" (DSSE-KMS) or
+ /// - "sse-c"
+ ///
+ /// Supported keys:
+ /// - `aws_server_side_encryption`
Review Comment:
```suggestion
/// - `aws_server_side_encryption`
/// - `server_side_encryption`
```
##########
src/aws/builder.rs:
##########
@@ -1202,17 +1226,37 @@ fn parse_bucket_az(bucket: &str) -> Option<&str> {
#[derive(PartialEq, Eq, Hash, Clone, Debug, Copy, Serialize, Deserialize)]
#[non_exhaustive]
pub enum S3EncryptionConfigKey {
- /// Type of encryption to use. If set, must be one of "AES256" (SSE-S3),
"aws:kms" (SSE-KMS), "aws:kms:dsse" (DSSE-KMS) or "sse-c".
+ /// Type of encryption to use.
+ ///
+ /// If set, must be one of
+ /// - "AES256" (SSE-S3),
+ /// - "aws:kms" (SSE-KMS),
+ /// - "aws:kms:dsse" (DSSE-KMS) or
+ /// - "sse-c"
+ ///
+ /// Supported keys:
+ /// - `aws_server_side_encryption`
ServerSideEncryption,
- /// The KMS key ID to use for server-side encryption. If set,
ServerSideEncryption
- /// must be "aws:kms" or "aws:kms:dsse".
+ /// The KMS key ID to use for server-side encryption.
+ ///
+ /// If set, [ServerSideEncryption](Self::ServerSideEncryption) must be
"aws:kms" or "aws:kms:dsse".
+ ///
+ /// Supported keys:
+ /// - `aws_sse_kms_key_id`
KmsKeyId,
/// If set to true, will use the bucket's default KMS key for server-side
encryption.
/// If set to false, will disable the use of the bucket's default KMS key
for server-side encryption.
+ ///
+ /// Supported keys:
+ /// - `aws_sse_bucket_key_enabled`
Review Comment:
```suggestion
/// - `aws_sse_bucket_key_enabled`
/// - `sse_bucket_key_enabled`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
