alamb opened a new pull request, #8764: URL: https://github.com/apache/arrow-rs/pull/8764
# Which issue does this PR close? - follow on to https://github.com/apache/arrow-rs/pull/8756 # Rationale for this change @etseidl comments: https://github.com/apache/arrow-rs/pull/8756#discussion_r2481506257 > Not relevant to this PR, but I think this TODO has largely been addressed by https://github.com/apache/arrow-rs/pull/8376 which enabled skipping the decoding of the page statistics. While I was in here, I also wanted to capture the learning based on @mapleFU 's comment https://github.com/apache/arrow-rs/pull/8756#discussion_r2482281406 > The code looks good to me but the I don't know if the comment "not compressed" can be replaced, if decompress_buffer is called and decompressed_size == 0 , seems that it generally means something like "this page only have levels, but not have non-null values"? ( Point me out if I'm wrong) # What changes are included in this PR? Include some comments # Are these changes tested? No (there are no code changes) # Are there any user-facing changes? No, this is internal comments only. No code / behavior changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
