klion26 commented on code in PR #8768:
URL: https://github.com/apache/arrow-rs/pull/8768#discussion_r2494056155
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -60,6 +61,9 @@ pub(crate) enum PrimitiveVariantToArrowRowBuilder<'a> {
TimestampNanoNtz(VariantToTimestampNtzArrowRowBuilder<'a,
datatypes::TimestampNanosecondType>),
Time(VariantToPrimitiveArrowRowBuilder<'a,
datatypes::Time64MicrosecondType>),
Date(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Date32Type>),
+ Utf8(VariantToUtf8ArrowRowBuilder<'a, i32>),
+ LargeUtf8(VariantToUtf8ArrowRowBuilder<'a, i64>),
+ Binary(VariantToBinaryArrowRowBuilder<'a>),
Review Comment:
I think the builder is transform some `variant` to `arrow` type, and the
`Variant` has `primitive`/`shortstring`/`object`/`list`
[types](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md#encoding-types),
Here we want to handle the types for `Variant::Primitive`(include
`shortstring`) types, in
`shred_variant::make_variant_to_shredded_variant_arrow_row_builder`/`variant_to_arrow#make_variant_to_arrow_row_builder`
we have other match arms(for `objects/lists`), the whole match arms will equal
to all variant types.
For
> check is_primitive and will throw error if the request data type is not
primitive
I think this is for `NotYetImplementation Error`
And have an expert to confirm this is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
