klion26 commented on code in PR #8768:
URL: https://github.com/apache/arrow-rs/pull/8768#discussion_r2491036258
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -60,6 +61,9 @@ pub(crate) enum PrimitiveVariantToArrowRowBuilder<'a> {
TimestampNanoNtz(VariantToTimestampNtzArrowRowBuilder<'a,
datatypes::TimestampNanosecondType>),
Time(VariantToPrimitiveArrowRowBuilder<'a,
datatypes::Time64MicrosecondType>),
Date(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Date32Type>),
+ Utf8(VariantToUtf8ArrowRowBuilder<'a, i32>),
+ LargeUtf8(VariantToUtf8ArrowRowBuilder<'a, i64>),
+ Binary(VariantToBinaryArrowRowBuilder<'a>),
Review Comment:
IIUC, the logic of `VariantToBinaryVariantArrowRowBuilder` is different from
the Binary here, the `VariantToBinaryVariantArrowRowBuilder` is for the raw
`Variant`, and here we want to process for `Variant::Binary`. I tried reuse the
`VariantToBinaryVariantArrowRowBuilder`, it will contains the meta and other
things also, we only need the binary value here.
And for the builder, please correct me if I'm wrong, the `primitive` here is
for `variant`, not for the `DataTypes`, we put `Null`/`Boolean`/ `Uuid` in here
also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
