tobixdev commented on code in PR #8829:
URL: https://github.com/apache/arrow-rs/pull/8829#discussion_r2520073223
##########
arrow-cast/src/display.rs:
##########
@@ -352,7 +361,8 @@ impl From<ArrowError> for FormatError {
}
/// [`Display`] but accepting an index
-trait DisplayIndex {
+pub trait DisplayIndex {
+ /// Write the value of the underlying array at `idx` to `f`.
fn write(&self, idx: usize, f: &mut dyn Write) -> FormatResult;
Review Comment:
Maybe we should add a `len` method to make the trait more complete (?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
