tobixdev commented on PR #8829: URL: https://github.com/apache/arrow-rs/pull/8829#issuecomment-3531638186
@alamb Thanks for the review and the great suggestions! I think that these changes will make the API better. One thing that resulted from moving the `ArrayFormatterFactory` into `FormatOptions` is that we need some concept of equality / hashing the factories. For now, I've chosen to compare the pointers of the factories. If you think that an equality implementation based on the content of the formatter factory (which I guess will often be a `HashMap` that maps extension types to an `Arc<MyExtType>`), we can iterate further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
