BlakeOrth commented on PR #8801: URL: https://github.com/apache/arrow-rs/pull/8801#issuecomment-3530372949
@paleolimbot I've further refined this implementation and introduced the actual array type in this most recent PR. If you could find some time for another review and provide any thoughts I'd greatly appreciate it. I've highlighted a couple of key areas with some comments to hopefully make it a bit easier for reviewers. Any feedback outside of those areas is obviously welcome as well! Given the fact that the tests to both read and write both of the parquet types are working, I believe the functional components of this code are getting close. There's obviously plenty of additional validation, tests, docs etc. that need to be written. The size of this PR is already getting a bit large, so if anyone has input on how we might want to split the work into more easily reviewable parts to actually start pushing it through (once we finish getting consensus on this WIP) I'd be happy to consider that when converting this to "real" PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
