BlakeOrth commented on PR #8801: URL: https://github.com/apache/arrow-rs/pull/8801#issuecomment-3534058948
@paleolimbot As always, thank you for your thoughts! > I left a comment inline but I think removing the `type_hint` would be best unless there's something I'm missing. I left a quick response detailing my current thoughts around this. As stated there, I'm don't really feel too strongly about this and if my reasoning doesn't sway you I'm happy to remove the `type_hint` if we think that's the best way to move forward! > The `WkbArray` seems orthogonal to this work but if it helps you write nice tests go for it! Yes, I think it's an easy candidate to carve off into a separate PR. I think what will likely happen is, after we've reached a good consensus on this WIP, I will probably open separate "merge ready" PRs that take the code from this WIP, clean up names, error propagation, unit tests, doc strings etc. That way the scope of an individual PR is smaller and quicker to review, which based on my recent experience over in the DataFusion repo, is desirable for the core maintainers (and probably everyone else too!). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
