zhuqi-lucas commented on PR #8857: URL: https://github.com/apache/arrow-rs/pull/8857#issuecomment-3544725396
> This looks ok to me. I'm not up on all uses of this API so I wonder if down the road we can just get rid of the preloading options and require use of `ArrowReaderOptions` if one wants control over page index loading. > > I think for now we should add a note to `with_preload_column_index` and `with_preload_offset_index` that settings in `ArrowReaderOptions` might override, as this is non-obvious. Thank you @etseidl for review and good suggestion, i added comments in latest commit. And i also created a follow-up ticket, we may can get rid of the reloading options and require use of `ArrowReaderOptions`. https://github.com/apache/arrow-rs/issues/8862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
