alamb commented on PR #8857: URL: https://github.com/apache/arrow-rs/pull/8857#issuecomment-3547268736
> This looks ok to me. I'm not up on all uses of this API so I wonder if down the road we can just get rid of the preloading options and require use of `ArrowReaderOptions` if one wants control over page index loading. > > I think for now we should add a note to `with_preload_column_index` and `with_preload_offset_index` that settings in `ArrowReaderOptions` might override, as this is non-obvious. I agree the current state of the structures is confusing (nothing that you did @zhuqi-lucas). In my opinion part of the confusion stems from having `ParuetObjectReader` responsible both for the IO with object_store AND for reading/caching the ParquetMetadata I think those are separate concerns and in an ideal API they wouldn't be in the same object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
