vustef opened a new pull request, #8863: URL: https://github.com/apache/arrow-rs/pull/8863
# Which issue does this PR close? No issue yet, please let me know if I should create one. # Rationale for this change https://github.com/apache/arrow-rs/pull/8715 introduced row numbers feature last week. However, it had a bug, which luckily for us @scovich pointed out soon after the merge. The issue is that the row numbers are produced in ordinal-based order of the row groups, instead of user-requested order of row groups. The former is wrong, and is being fixed here by switching to user-requested order. # What changes are included in this PR? Just fixing the bug as explained above, and adding test. Also addressing two small comments from post-merge review: https://github.com/apache/arrow-rs/pull/8715#pullrequestreview-3474400469 # Are these changes tested? Yes. # Are there any user-facing changes? No, this wasn't released yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
