etseidl commented on code in PR #8863:
URL: https://github.com/apache/arrow-rs/pull/8863#discussion_r2539005243
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -625,12 +625,11 @@ impl ArrowReaderOptions {
pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self {
Review Comment:
I also made this comment in the original PR, but maybe we could change this
to
```rust
pub fn set_virtual_columns(&mut self, virtual_columns: Vec<FieldRef>) ->
Result<()> {
```
to avoid the panic. If we squeak this in before `57.1.0` ships it wouldn't
be an API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
