wgtmac commented on code in PR #48170:
URL: https://github.com/apache/arrow/pull/48170#discussion_r2544156807
##########
cpp/src/parquet/properties.h:
##########
@@ -322,7 +322,49 @@ class PARQUET_EXPORT WriterProperties {
content_defined_chunking_enabled_(
properties.content_defined_chunking_enabled()),
content_defined_chunking_options_(
- properties.content_defined_chunking_options()) {}
+ properties.content_defined_chunking_options()) {
+ for (const auto& [col_path, col_props] : properties.column_properties_) {
Review Comment:
I just noticed that `WriterProperties` and `WriterProperties::Builder` use
different forms to represent column properties. Is it possible to simplify this
by using the same form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
