adamreeve commented on code in PR #48170:
URL: https://github.com/apache/arrow/pull/48170#discussion_r2544199683
##########
cpp/src/parquet/properties.h:
##########
@@ -322,7 +322,49 @@ class PARQUET_EXPORT WriterProperties {
content_defined_chunking_enabled_(
properties.content_defined_chunking_enabled()),
content_defined_chunking_options_(
- properties.content_defined_chunking_options()) {}
+ properties.content_defined_chunking_options()) {
+ for (const auto& [col_path, col_props] : properties.column_properties_) {
Review Comment:
I think the builder needs to work this way so that different column-specific
properties can be changed as well as changing default column properties without
the order of operations affecting the result. I don't think the
`WriterProperties` can be changed to use the Builder's representation without
breaking the API as `ColumnProperties` is part of the public API and returned
as a reference:
https://github.com/apache/arrow/blob/e6ad2c487f78888c0ba94427ed4c3915fadc1d46/cpp/src/parquet/properties.h#L911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
