pitrou commented on code in PR #48195:
URL: https://github.com/apache/arrow/pull/48195#discussion_r2556061974
##########
cpp/src/arrow/util/bit_stream_utils_internal.h:
##########
@@ -381,6 +384,17 @@ inline bool BitReader::GetVlqInt(Int* v) {
max_size = bytes_left();
data = buffer_ + (max_bytes_ - max_size);
}
+#else
Review Comment:
I agree with @k8ika0s that this is adding a bunch of BE-specific code where
we could on the contrary simplify the existing code, since the "cache" isn't
really useful here: the decoding step is the same nevertheless.
I'm experimenting with this simplification in this PR:
https://github.com/apache/arrow/pull/48237 , mostly to run benchmarks as the
code should be correct anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
